Did Darth sion die in knights of the old republic 2

Yes. The Jedi Exile was unable to physically defeat him, but eroded his will to the point where he gave up his connection to the Dark Side and died.