Are wow add-ons legal

No, addons are not illegal or against the Policies of Blizzard/World of Warcraft. If Blizzard did not approve of addons, they would not have put in support for addons.