Do you lose all your characters when you upgrade your wow account

No, you do not lose any characters when you upgrade your account. The only times you lose your characters is if you happen to delete them, or if Blizzard bans your account and deletes them.