Which game is better star wars battlefront 2 or knights of the old republic

It depends what type of game you're after. KotOR is an RPG, whereas SWBF2 is a shooter. However, in terms of overall quality, KotOR still remains one of the finest games Bioware have ever produced, and I'd highly recommend it.